-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terminal-wide report command #1709
Conversation
…onkTerminal into helpdesk-report
Not necessary, but is it possible to use nocoDB as an air table alternative? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command shouldn't be "report" but "support".
We already use "reports" naming for other features and we don't want to have that confusion here.
Ooh that looks nice! airtable is not cheap, so I could look into this once the engagement grows out of scope for Google Sheets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments below.
On top of that can you do a quick thing for me?
Can we change it to this and put it inside:
Here is the text:
[info]Get API keys from data providers to access more features.[/info]
For more instructions use: 'keys'
On top of that when displaying terminal version, mine is showing vREPLACE_ME, which is not ideal. Can you check if the str is different than REPLACE_ME and if it's not just not display any version?
Thanks!!
@DidierRLopes @minhhoang1023 the vREPLACE_ME will be fixed by the time we do the next release. This relates to poetry not installing the openbb_terminal package correctly into the local environment. Known issue. Let's keep it out of the scope of this PR, please |
Thought it would be a 2 liner change and therefore worth the protection added here - seems sloppy currently. Since I use advanced mode I only saw this now. |
It's 2 symbols if you hardcode the version number =) . I was trying to fetch the version number from pyproject.toml on boot and it fails in some environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 🙌🏽🙌🏽🙌🏽 legooo
BOOM! MERGED! |
* fix tz autocomplete * fix regression introduced by support command #1709 Co-authored-by: James Maslek <[email protected]>
Description
Confluence page: https://openbb.atlassian.net/wiki/spaces/ENG/pages/80936995/Helpdesk+Implementation
Note:
If you want to test it, please send me a DM and I'll share with you the Airtable access keys
As next time while collecting feedback, reports should be sent to an API gateway, which is then connected with Airtable. this is such that we don't expose the key with write permissions
Summary of the change / bug fix.
Link # issue, if applicable.
Screenshot of the feature or the bug before/after fix, if applicable.
Relevant motivation and context.
List any dependencies that are required for this change.
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.