Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logger Tests #1707

Merged
merged 55 commits into from
May 3, 2022
Merged

Add Logger Tests #1707

merged 55 commits into from
May 3, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Apr 17, 2022

Description

Bringing coverage for logging functionality from 0% to 98%.

How has this been tested?

Ran tests

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the tests Test-related work label Apr 17, 2022
@colin99d colin99d requested a review from Chavithra April 17, 2022 20:26
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is generating files.

tmp/MOCK_COMMIT_HASH_MOCK_SESSION_ID.2022-04-17_21.log Outdated Show resolved Hide resolved
@colin99d
Copy link
Contributor Author

colin99d commented Apr 26, 2022

Chavi's TODOs:

  • Replace delete with temporary folder
  • Refactor tests to not use the mock classes with mocker.Mock()

@DidierRLopes
Copy link
Collaborator

@Chavithra did you have time to look at this?

@Chavithra Chavithra merged commit 4d62b26 into main May 3, 2022
@Chavithra Chavithra deleted the loggertests branch May 3, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants