Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Coinbase broker functions #1696

Merged
merged 11 commits into from
Apr 17, 2022
Merged

Tests for Coinbase broker functions #1696

merged 11 commits into from
Apr 17, 2022

Conversation

marcelonyc
Copy link
Contributor

@marcelonyc marcelonyc commented Apr 13, 2022

Description

Added tests for Coinbase portfolio/bro/cb functions. The test covers: account, orders, deposits.

I skipped a history test because the function usability is not clear (to me :) ). It is currently set to show holds, not history. If someone can explain the intention of history, I can make changes.

  • Summary of the change / bug fix.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@marcelonyc marcelonyc closed this Apr 13, 2022
@marcelonyc marcelonyc reopened this Apr 14, 2022
@colin99d colin99d added the tests Test-related work label Apr 17, 2022
@colin99d colin99d self-requested a review April 17, 2022 01:07
@colin99d colin99d merged commit f0911fa into OpenBB-finance:main Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants