Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default env for packaged apps #1693

Merged
merged 14 commits into from
Apr 21, 2022
Merged

Default env for packaged apps #1693

merged 14 commits into from
Apr 21, 2022

Conversation

piiq
Copy link
Contributor

@piiq piiq commented Apr 12, 2022

Introduces 3 things

  • A json with defaults is removed in favor of a single .env file that resides in REPO_PATH
  • Added cross platform and cross env (both conda and venv are working) to the specfile
  • Fixes a printout bug in integration tests reporting

@piiq piiq added the feat XS Extra small feature label Apr 12, 2022
@piiq
Copy link
Contributor Author

piiq commented Apr 12, 2022

@Chavithra I've adjusted the pathex param in the specfile in a way that it is expected to work with both conda env and venv so there shouldn't be a problem with packaging of statsmodels and linearmodels datasets. Check it out

Note:
I am open to splitting mac and win specfiles.

The pros for this:

  • more control over each platform

The cons for this:

  • need to maintain x2 (or x3 ) the amount of configs

the code is identical for the both platforms. The difference is only what's on this image
image

Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me on the build. Although I had to do this still on the .spec file.

import sys
sys.path.insert(0, 'C:\Users\Andrew\Desktop\gamestonk MASTER FILE\GamestonkTerminal')

Then it could find "openbb_terminal.loggers"

But both files for statsmodel and linearmodels came in.

Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@piiq piiq merged commit a5b414b into main Apr 21, 2022
@piiq piiq deleted the packaged-app-default-env branch April 21, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants