Requests using style fix #1691
Merged
Requests using style fix #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PzaThief
force-pushed
the
requests-style-fix
branch
from
aa30f1c
to
3f476c0
Compare
|
Nice! Looks like black is failing on the CI, so you can just fix that up by running |
PzaThief
force-pushed
the
requests-style-fix
branch
from
3f476c0
to
3806f63
Compare
thanks!. I applied black formatting. could you check if it can be merged again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are many json() function calls of requests.response repeatedly.
If it call json() once and store in variables, it is faster than call json() several times.
of coures most of waiting time is for request, but I expect many a little makes a mickle.
and stocktwits_model.get_messages and stocktwits_model.get_stalker had a bug about limit.
it takes array of limit+1 length not limit. so I fixed it and changed style for improve performance.