Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bots plots refactor.. 90% html size decrease! #1686

Merged
merged 28 commits into from
Apr 15, 2022

Conversation

tehcoderer
Copy link
Contributor

@tehcoderer tehcoderer commented Apr 11, 2022

Drafting for visibility

Juan Local plotly.js for all html charts.

Top 2 are the same 15min/30days charts.. Before and after. 🚀
image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@tehcoderer tehcoderer added enhancement Enhancement refactor Refactor code discord Discord bot labels Apr 11, 2022
@tehcoderer tehcoderer marked this pull request as ready for review April 12, 2022 22:31
@DidierRLopes DidierRLopes merged commit 07c053f into OpenBB-finance:main Apr 15, 2022
@tehcoderer tehcoderer deleted the bots-plots-refactor branch November 6, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discord Discord bot enhancement Enhancement refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants