openbb_terminal tests: coverage (61% -> 65%)

[colin99d]

Description

Expanding general terminal tests. Will plan on being ready to merge on Sunday night regardless of how many tests have been written: Adding tests to:

• Keys Controller
• Econometrics Controller
• Settings Controller
• common/qa_view

@JerBouma I also added some enhancements to the econometrics controller to make it more robust. Can you please confirm these changes are desired?

@Chavithra the tests pass now. I BELIEVE matplotlib.pyplot.show is now fully mocked.

Also, Fixes #1667

How has this been tested?

Ran pytest.

Checklist:

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
• New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

[colin99d]

@Chavithra I cannot figure out how to mock matplotlib so that it will not show graphs in tests/openbb_terminal/common/quantitative_analysis/test_qa_view.py. Any advice?

[JerBouma]

@colin99d Looks good to me! 👍

[Chavithra]

There is an issue on my Windows :

>           path_cmd = dir_path.split("openbb_terminal/")[1].replace("/", "_")
E           IndexError: list index out of range

Maybe that's related to the OS separator.

========================================================================================================================== short test summary info ========================================================================================================================== 
FAILED tests/openbb_terminal/common/quantitative_analysis/test_qa_view.py::test_display_summary - IndexError: list index out of range
FAILED tests/openbb_terminal/common/quantitative_analysis/test_qa_view.py::test_display_cdf[None] - IndexError: list index out of range
FAILED tests/openbb_terminal/common/quantitative_analysis/test_qa_view.py::test_display_seasonal[False] - IndexError: list index out of range
FAILED tests/openbb_terminal/common/quantitative_analysis/test_qa_view.py::test_display_seasonal[True] - IndexError: list index out of range
FAILED tests/openbb_terminal/common/quantitative_analysis/test_qa_view.py::test_display_normality - IndexError: list index out of range
======================================================================================================================= 5 failed, 23 passed in 5.71s ========================================================================================================================

[Chavithra]

Is there an issue there ?

[tehcoderer]

@Chavithra can you try with my changes and let me know if that resolves it.. haha get it? I'll walk myself out...

[colin99d]

@Chavithra this is not an issue.