Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cost to borrow of stocks. Data from IBKR #1663

Merged
merged 11 commits into from
Apr 15, 2022

Conversation

guanquann
Copy link
Contributor

@guanquann guanquann commented Apr 9, 2022

Description

Add cost to borrow of stocks. Data from IBKR. (note: this is a repost since I messed up with my previous pull req. earlier)

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the feat XS Extra small feature label Apr 9, 2022
@DidierRLopes
Copy link
Collaborator

DidierRLopes commented Apr 9, 2022

Since you changed the help text on the dps menu you need to run this command:
pytest tests/openbb_terminal/stocks/dark_pool_shorts/test_dps_controller.py --record-mode=rewrite

This will replace the "test" files and add the CTB command that you just added!

@DidierRLopes
Copy link
Collaborator

@guanquann seems you just need to run black on this and should be good!

@guanquann
Copy link
Contributor Author

@DidierRLopes hopefully it will work this time haha!

@jmaslek jmaslek merged commit 73187d9 into OpenBB-finance:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants