Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Fraud Command #1660

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Fixes Fraud Command #1660

merged 2 commits into from
Apr 8, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Apr 8, 2022

Description

Unfortunately, Alphavantage is providing incorrect values for accumulated depreciation. I have reached out to them by email but here is a temporary fix for now. ALSO this fixes and issue where AlphaVantage would not work without a key. Fixes #1656.

How has this been tested?

Ran pytest.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Apr 8, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Apr 8, 2022

works on my end

Screen Shot 2022-04-08 at 12 20 51 PM

@jmaslek jmaslek merged commit 002d1a4 into main Apr 8, 2022
@DidierRLopes DidierRLopes deleted the fraudfix branch May 30, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fraud command broken[Bug]
2 participants