-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Necessary files to fix the windows installer splash screen #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chavithra
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
piiq
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I was digging into it I saw a couple of things:
- The defaults json can go away in favour of a
.env
file with defaults that bundles with the package. This.env
file is bundled to theREPO_PATH
and should be picked up by the terminal on bootup. - In packaged apps a
.env
file inREPO_PATH
will be overwritten by each update. This would require setting up the keys through the settings menu after every update. To have some sort of transferability between releases we can look at creating a.env
file outside ofREPO_PATH
. For example in user home. This already works on all platforms for prompt toolkit (the prompt toolkit history file is in user home). - If we set up the python environment identically (python 3.8 from conda) on Windows and macOS build machines, we can leverage the cross-platform compatibility features that are bundled into pyinstaller. The specfile will be identical for all supported platforms (win, mac, linux).
I'll make a separate draft PR with the proposed changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix here was to put the "OPENBB_DEFAULTS.json" file into the main folder and not the openbb_terminal folder on build.
I also created the template folder inside build/nsis for future builds.
@piiq Can you verify I didn't break anything on the Mac installer - I changed the name of some files on your side, I think I got them all. Also check that you might not be settings the proper defaults as well if this file isn't in the main folder on your end.
@Chavithra Verify that the windows install works now per the docs