Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Necessary files to fix the windows installer splash screen #1653

Merged
merged 12 commits into from
Apr 12, 2022

Conversation

andrewkenreich
Copy link
Contributor

Fix here was to put the "OPENBB_DEFAULTS.json" file into the main folder and not the openbb_terminal folder on build.

I also created the template folder inside build/nsis for future builds.

@piiq Can you verify I didn't break anything on the Mac installer - I changed the name of some files on your side, I think I got them all. Also check that you might not be settings the proper defaults as well if this file isn't in the main folder on your end.

@Chavithra Verify that the windows install works now per the docs

@andrewkenreich andrewkenreich added the bug Fix bug label Apr 7, 2022
@andrewkenreich andrewkenreich self-assigned this Apr 7, 2022
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was digging into it I saw a couple of things:

  1. The defaults json can go away in favour of a .env file with defaults that bundles with the package. This .env file is bundled to the REPO_PATH and should be picked up by the terminal on bootup.
  2. In packaged apps a .env file in REPO_PATH will be overwritten by each update. This would require setting up the keys through the settings menu after every update. To have some sort of transferability between releases we can look at creating a .env file outside of REPO_PATH. For example in user home. This already works on all platforms for prompt toolkit (the prompt toolkit history file is in user home).
  3. If we set up the python environment identically (python 3.8 from conda) on Windows and macOS build machines, we can leverage the cross-platform compatibility features that are bundled into pyinstaller. The specfile will be identical for all supported platforms (win, mac, linux).

I'll make a separate draft PR with the proposed changes

@piiq piiq merged commit ccb0b6c into main Apr 12, 2022
@piiq piiq deleted the WindowsInstallerFix branch April 12, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants