Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces coingecko deprecated commands #1650

Merged
merged 23 commits into from
Apr 13, 2022
Merged

Replaces coingecko deprecated commands #1650

merged 23 commits into from
Apr 13, 2022

Conversation

jose-donato
Copy link
Contributor

Description

Addresses #1576 by removing cgplatforms and cgproducts (that were deprecated from coingecko) and adds cr command to check crypto interest rates (for both supplying and borrowing).

image

How has this been tested?

Locally and added tests

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jose-donato jose-donato changed the title removes cgproducts and cgplatforms and replaces with cr Replaces coingecko deprecated commands Apr 6, 2022
@jose-donato jose-donato added the feat XS Extra small feature label Apr 6, 2022
@minhhoang1023
Copy link
Contributor

minhhoang1023 commented Apr 7, 2022

Niceee one! 🚀

A few comments:

1. Borrow type is throwing an error for me ;(
image

**2. When searching for a platform/ coin that doesn't exist / incorrect format **

image

image

3. Would be nice to have the rates sorted from highest to lowest
image

4. We also need to remove the deprecated commands and add new one to the api.

5. What do you think about plotting the results as a chart?
It's much easier to see it visually and see which platforms provide the highest yield given the assets.

Something like this? (Horizontal bar would be better here though)
image

Let me know what you think! Overall, very nice work! ✨

@colin99d colin99d linked an issue Apr 8, 2022 that may be closed by this pull request
@minhhoang1023 minhhoang1023 merged commit 6704023 into main Apr 13, 2022
@minhhoang1023 minhhoang1023 deleted the fix_cgproducts branch April 13, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] crypto/ov/cgproducts - Error: Incorrect path.
4 participants