Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing in on 90% Bot Coverage #1646

Merged
merged 28 commits into from
Apr 10, 2022
Merged

Closing in on 90% Bot Coverage #1646

merged 28 commits into from
Apr 10, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Apr 6, 2022

Description

Wrote some more tests for bots/

How has this been tested?

The tests passed.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d requested a review from tehcoderer April 6, 2022 01:36
@colin99d colin99d marked this pull request as draft April 6, 2022 01:36
@colin99d colin99d added the tests Test-related work label Apr 8, 2022
@colin99d colin99d marked this pull request as ready for review April 9, 2022 12:04
Copy link
Contributor

@tehcoderer tehcoderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah!!! All Passing and workingg.

Excellent work on all the tests!!! Lets get this merged 🚀

@DidierRLopes DidierRLopes merged commit 617266a into main Apr 10, 2022
@DidierRLopes DidierRLopes deleted the morebottests branch May 30, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants