Added check for valid Coinbase product, including delisted checking

[marcelonyc]

This change fixes a bug I reported yesterday. Fixes #1624

When loading a Coinbase portfolio, the list cointains USD as well as delisted products(XRP). The load fails when checking prices for invalid pairs or delisted products.

The fix does 3 things

• Confirm the pair is valid in Coinbase
• Checks for a message indicating the pair is delisted
• Returns an Exception if it fails to get a price for that pair that does not match the previous checks

Testing
Testing requires an account on Coinbase PRO. I confirmed my portfolio loaded as expected.

What is missing
Multiple portfolios: In Coinbase Pro you can have multiple portfolios. Each with its own API-KEY-SECRET. Adding this feature will require additional changes to key management and a decision on how to handle multiple portfolios within a single broker.

Description

• Summary of the change / bug fix.
• Link # issue, if applicable.
• Screenshot of the feature or the bug before/after fix, if applicable.
• Relevant motivation and context.
• List any dependencies that are required for this change.

How has this been tested?

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

Checklist:

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
• New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

[piiq]

Thanks for the patch @marcelonyc !

I saw that the coinbase menu is not covered by unit tests. Will you be open to make another PR adding tests to this menu?

[marcelonyc]

@piiq I will try to contribute the tests for the Coinbase menu. However, I would need to get more proficient with pytest. If someone gets to write the tests before me, I will not take offense :)

[minhhoang1023]

tests

we actually just updated our Test Documentation, so it should be easy to follow! Feel free to ping me or our Test master @Chavithra if you have any questions