Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue generating crypto report #1632

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fixed issue generating crypto report #1632

merged 2 commits into from
Apr 5, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Apr 4, 2022

Description

Fixes #1556

How has this been tested?

Ran a crypto report and no error was shown.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Apr 4, 2022
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Colin, this fixes the issue, let's merge it.

P.S. I wanted to update the notebooks for the reports this week to follow the example from the dd notebook.

@piiq piiq merged commit ea0a3bb into main Apr 5, 2022
@piiq piiq deleted the fixreports branch April 5, 2022 09:34
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Reports - Some reports are not creating the file and are showing execution errors.
2 participants