Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto cannot load some crypto pairs #1627

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Conversation

minhhoang1023
Copy link
Contributor

@minhhoang1023 minhhoang1023 commented Apr 4, 2022

image

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@minhhoang1023 minhhoang1023 added the bug Fix bug label Apr 4, 2022
@minhhoang1023 minhhoang1023 changed the title Fix coin_map_df returns nan Crypto cannot load some crypto pairs Apr 4, 2022
@minhhoang1023 minhhoang1023 merged commit 1f92bb9 into main Apr 4, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 6, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 7, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 12, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 12, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 12, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 12, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 12, 2022
mrriteshranjan added a commit to mrriteshranjan/OpenBBTerminal that referenced this pull request Apr 12, 2022
@DidierRLopes DidierRLopes deleted the fix-bug-load-crypto branch May 30, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to load data for some cryptocurrencies (LTC-USD@Coinbase for example)
2 participants