Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerful stock search #1617

Merged
merged 11 commits into from
Apr 3, 2022
Merged

Powerful stock search #1617

merged 11 commits into from
Apr 3, 2022

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes added the feat S Small T-Shirt size Feature label Apr 2, 2022
@colin99d
Copy link
Contributor

colin99d commented Apr 2, 2022

Imagine customer service so good you message someone on twitter and the feature is live 3 hours later.

@DidierRLopes
Copy link
Collaborator Author

@colin99d you made it here:
https://twitter.com/hashtag/lifeatopenbb?src=hashtag_click

@DidierRLopes
Copy link
Collaborator Author

DidierRLopes commented Apr 2, 2022

@Chavithra I need you!! It's failing in here:

pytest tests/openbb_terminal/stocks/test_stocks_controller.py --record-mode=rewrite -k call_search

What does this mean?

            if called_args or called_kwargs:
>               mock.assert_called_once_with(*called_args, **called_kwargs)
E               AssertionError: Expected 'mock' to be called once. Called 0 times.

@Chavithra
Copy link
Contributor

Chavithra commented Apr 3, 2022

Modifications :

  • Renamed amount => limit, inside :
    • tests\openbb_terminal\stocks\test_stocks_helper.py
  • Remove parameter like "--country=''", apparently the following method doesn't ignore the single quote character :
    • ArgumentParser.parse_known_args

@DidierRLopes
Copy link
Collaborator Author

Thank you @Chavithra ❤️

@DidierRLopes DidierRLopes merged commit 1e24d02 into main Apr 3, 2022
@joshuabuildsthings
Copy link
Contributor

@DidierRLopes & @Chavithra - Thanks for this; it's going to be an amazing upgrade!

@DidierRLopes DidierRLopes deleted the stock-search branch May 30, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants