Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging for users that don't rename parent folder to OpenBBTerminal #1613

Merged
merged 15 commits into from
Apr 4, 2022
Merged

Fix logging for users that don't rename parent folder to OpenBBTerminal #1613

merged 15 commits into from
Apr 4, 2022

Conversation

DidierRLopes
Copy link
Collaborator

No description provided.

@DidierRLopes DidierRLopes added the bug Fix bug label Apr 2, 2022
@Chavithra Chavithra added the do not merge Label to prevent pull request merge label Apr 3, 2022
@Chavithra
Copy link
Contributor

Chavithra commented Apr 3, 2022 •
edited
Loading

Did the following :

  • Fixed a bug on filtering PII information from log files
  • Refactored the way we use the following files : .env, OPENBB_DEFAULTS.json
  • Moved : openbb_terminal.log to openbb_terminal.core.log

We should now be able to call the terminal.py from outside the repository like this :

python GamestonkTerminal\terminal.py
python OpenBBTerminal\terminal.py

Which is not handled by the current main.

@Chavithra Chavithra requested a review from piiq April 3, 2022 11:06
@Chavithra Chavithra removed the do not merge Label to prevent pull request merge label Apr 3, 2022
@Chavithra
Copy link
Contributor

@piiq Can you take a look ?

@DidierRLopes DidierRLopes mentioned this pull request Apr 3, 2022
Closed
@piiq piiq merged commit 39d6955 into main Apr 4, 2022
@piiq piiq deleted the fix-log branch April 4, 2022 09:29
@Chavithra Chavithra linked an issue Apr 4, 2022 that may be closed by this pull request
[Bug] /stocks/options/ $ oi Error: 'NoneType' object is not subscriptable #1626
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek jmaslek approved these changes

@piiq piiq piiq approved these changes

@Chavithra Chavithra Awaiting requested review from Chavithra

@LBolte29 LBolte29 Awaiting requested review from LBolte29

Assignees
No one assigned
Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] /stocks/options/ $ oi Error: 'NoneType' object is not subscriptable
5 participants
@DidierRLopes @Chavithra @piiq @jmaslek @colin99d