Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get into oanda submenu #1611

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Get into oanda submenu #1611

merged 2 commits into from
Apr 2, 2022

Conversation

buahaha
Copy link
Contributor

@buahaha buahaha commented Apr 2, 2022

Description

  • Summary of the change / bug fix.

Comment-out not needed checks for to and from currency.
Add oanda forex source in dictionary.

  • Link # issue, if applicable.

Fix #1608

  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.

Can not login using Oanda valid info.

  • List any dependencies that are required for this change.

None.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.

Insert proper environment variables, run terminal in debug mode, and use forex/oanda menu

  • Provide instructions so we can reproduce.

Try set the account type using -t. Now it's renamed to -at that stands for account type

  • Please also list any relevant details for your test configuration.

Working Oanda account.

Checklist:

No tests, as this is very simple fix, and I'm not sure, if you follow with my reasoning.

Again, it's basic. Enables only login.

Others

  • I have performed a self-review of my own code.

No.

  • I have commented my code, particularly in hard-to-understand areas.

No. I have commented out, in my opinion, not needed part of checking for valid currency pair before entering Oanda submenu

  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.

Overkill for simple fix, but I'm taking this into consideration ;)

  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

Comment-out not needed checks for `to` and `from` currency.
Add `oanda` forex source in dictionary.
Fix #1608
@colin99d colin99d self-requested a review April 2, 2022 12:44
@colin99d colin99d added the bug Fix bug label Apr 2, 2022
@colin99d
Copy link
Contributor

colin99d commented Apr 2, 2022

Thanks for the bug fix! Once CI passes we can merge.

@colin99d colin99d merged commit 0f7154b into OpenBB-finance:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Keys/Oanda Cannot Set - Error: argument -t/--account_type: conflicting option string: -t
2 participants