-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Open Source menu #1603
New Open Source menu #1603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piiq should be good now |
@jose-donato not so fast |
@jose-donato can you add an .openbb script for integration tests? in addition to this I would like to propose renaming the |
renamed to the third time is the charm (hopefully) |
@DidierRLopes @Chavithra it only happened after pulling branches from main, do you know what is wrong here? |
@jose-donato just tested it. works great, although it took VERY long to generate redis' star history possible to add github to the keys menu? |
yes it takes a lot of time. not sure we can optimize it though. only if we do the requests in parallel! i researched a little bit and it looks like we can only get the star history this way. yea i forgot about that! will add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for me
@Chavithra can you have a look if logging is implemented correctly here?
I think we need to filter the user agent like in this example : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks José !
This reverts commit 01391c2.
This reverts commit 6e86127.
This reverts commit 4d43ee2.
…finance#1603)""""" This reverts commit 9c350b7.
…penBB-finance#1603)"""""" This reverts commit b6f0a6d.
Description
This PR adds a new menu to alternative context. This new menu aims to cover open source data and uses Github api as source.
It contains three different commands:
rs
: displays a certain repository summarysh
: displays star history of a certain repository overtimetr
: displays top repos sorted by stars or forks and can be filtered by categories (e.g., finance)Three features to start but github api is nice and has lot of data. This menu will help users analyse different repos and other open source data.
How has this been tested?
Tested controller and view/model.
Checklist:
Others
pre-commit install
.pytest tests/...
.