-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding bot tests #1561
Expanding bot tests #1561
Conversation
…Terminal into morebottests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The tests looks good to me and passes on my instance.
- Can we do something to make having bot dependencies not mandatory to run
pytest
? I think people will get into thisdisnake not installed
issue. - Questions about these html files and images which are generated while running the test :
- Are they temporary files ?
- Are they different each time we run the tests ?
- Is it necessary to push them into git ?
Good catch! I added those to the gitignore! |
Description
Adding tests to the following areas:
After this the last major group of tests I will need to write is over the stocks folder.
How has this been tested?
Ran the tests.
Checklist:
Others
pre-commit install
.pytest tests/...
.