Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding bot tests #1561

Merged
merged 30 commits into from
Apr 2, 2022
Merged

Expanding bot tests #1561

merged 30 commits into from
Apr 2, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Mar 26, 2022

Description

Adding tests to the following areas:

  • Groupme
  • Slack
  • Telegram
  • helpers.py
  • load_candle.py

After this the last major group of tests I will need to write is over the stocks folder.

How has this been tested?

Ran the tests.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the tests Test-related work label Mar 26, 2022
@colin99d colin99d marked this pull request as draft March 26, 2022 14:42
@colin99d colin99d marked this pull request as ready for review April 1, 2022 20:22
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The tests looks good to me and passes on my instance.
  2. Can we do something to make having bot dependencies not mandatory to run pytest ? I think people will get into this disnake not installed issue.
  3. Questions about these html files and images which are generated while running the test :
    • Are they temporary files ?
    • Are they different each time we run the tests ?
    • Is it necessary to push them into git ?

@colin99d
Copy link
Contributor Author

colin99d commented Apr 1, 2022

  1. The tests looks good to me and passes on my instance.

  2. Can we do something to make having bot dependencies not mandatory to run pytest ? I think people will get into this disnake not installed issue.

  3. Questions about these html files and images which are generated while running the test :

    • Are they temporary files ?
    • Are they different each time we run the tests ?
    • Is it necessary to push them into git ?

Good catch! I added those to the gitignore!

@colin99d colin99d merged commit 6538c0c into main Apr 2, 2022
@colin99d colin99d deleted the morebottests branch April 2, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants