Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] SDK openbb.stocks.sia.maketcap --> missing r #3510

Closed
deeleeramone opened this issue Nov 22, 2022 · 4 comments
Closed

[Bug] SDK openbb.stocks.sia.maketcap --> missing r #3510

deeleeramone opened this issue Nov 22, 2022 · 4 comments
Assignees
@jmaslek
Labels
bug Fix bug good first issue platform OpenBB Platform

Comments

@deeleeramone
Copy link
Contributor

Screenshot 2022-11-21 at 9 58 06 PM
@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels Nov 22, 2022
@deeleeramone
Copy link
Contributor Author

Also seems to be missing a few arguments.

Screenshot 2022-11-21 at 10 07 55 PM

@PedroMirao
Copy link

pls assign it to me! :)

@jmaslek jmaslek assigned jmaslek and unassigned PedroMirao Dec 6, 2022
@jmaslek jmaslek mentioned this issue Dec 6, 2022
Closed
jmaslek added a commit to jmaslek/OpenBBTerminal that referenced this issue Dec 8, 2022
@jmaslek
docstring + OpenBB-finance#3510
a2d2118
@hjoaquim hjoaquim mentioned this issue Dec 15, 2022
Merged
jmaslek added a commit that referenced this issue Dec 15, 2022
@jmaslek
Editing the SDK functions (#3723)
4266c69 
* etf compare into sdk

* docstring + #3510

* #3712

* Add stats to sdk + isort folder

* Add filter function

* add 10 insider functions

* add new fa models

* update equity.ipynb
@sbshah97
Copy link

sbshah97 commented Jan 3, 2023

Is this completed? Would love to contribute. Any good first issues?

@jmaslek
Copy link
Collaborator

jmaslek commented Jan 3, 2023

Hey @sbshah97. Yes this got taken care of!

A good first issue could be #3865!

@jmaslek jmaslek closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmaslek jmaslek

Labels
bug Fix bug good first issue platform OpenBB Platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sbshah97 @jmaslek @hjoaquim @PedroMirao @deeleeramone