Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Portfolio fails when trade happened "today" #2450

Closed
jfarid27 opened this issue Aug 29, 2022 · 1 comment
Closed

[Bug] Portfolio fails when trade happened "today" #2450

jfarid27 opened this issue Aug 29, 2022 · 1 comment
Labels
bug Fix bug portfolio Portfolio menu

Comments

@jfarid27
Copy link
Contributor

jfarid27 commented Aug 29, 2022

Describe the bug
The portfolio engine fails if a trade has occurred on the current day. This is a very odd time dependent bug that requires historical data fetching not to return the daily date.

To Reproduce

  1. I'm not sure how to get Yahoo not to fetch the current day date, besides try this around 8am EST.
  2. Pick today in the format %Y-%m-%d and add it to your csv portfolio, or portfolio_trades.csv.
  3. Navigate to portfolio and load the file. It should fail with an index out of bounds error.

Screenshots
TBD

Desktop (please complete the following information):

  • OS: Big Sur
  • Python version 3.8.13

Additional context
None

@deeleeramone
Copy link
Contributor

If trade = today, then there would be no daily data available until after market close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug portfolio Portfolio menu
Projects
None yet
Development

No branches or pull requests

2 participants