-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug] Crypto/OV/HM - limit of 50 returns Error: cannot convert float NaN to integer #2220
Comments
@deeleeramone the % here represents the daily percentage change in the currency - I've updated the help for the hm command to say the same, hopefully that helps? |
Co-authored-by: Colin Delahunty <[email protected]>
@soggyomelette One would eventually make that logical leap as a conclusion, but knowing the % change from today does little to help situations such as the screenshot above, the Top 20/40 Stable Coins. Ranking stable coins by a market cap value relative to the entire market makes all stable coins = 0% by the time you introduce rounding. This is why the large majority of coins are right on top of each other and is unreadable. |
It's just that looking at other heatmaps online (like this one https://www.tradingview.com/heatmap/stock/?color=change&dataset=SPX500&group=sector&size=market_cap_basic) I saw they used the percentage in the center to denote the same thing so I thought I would leave it unchanged. Also, looking at the code, it does in fact rank them relative to the category you choose but the market cap of some of the later stable coins is so minute that they get dwarfed by the much larger stable coins (https://www.coingecko.com/en/categories/stablecoins? for example check the market of $65B of USDT with even the 20th coin with $108M - it's almost a 1000x less |
Nicely done! |
When the limit touches 50, this error message displays.
When a
category
is selected, the % of market cap should then be calculated as relative to the % of the chosen category, and not the entire market cap of all cryptos. This is why everything is crowded into one tiny corner while the biggest pieces are fractions of one percent.The text was updated successfully, but these errors were encountered: