Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Incorrect log for reddit keys. #1733

Closed
penfold1972 opened this issue Apr 24, 2022 · 3 comments
Closed

[Bug] Incorrect log for reddit keys. #1733

penfold1972 opened this issue Apr 24, 2022 · 3 comments
Assignees
@lepla
Labels
bug Fix bug

Comments

@penfold1972
Copy link

penfold1972 commented Apr 24, 2022 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

Referring to file keys_controller.py

Line 358 logs test passed while line 359 displays keys failed. The log message needs the word passed changed to failed.

To Reproduce
Steps(from the start) and commands to reproduce the behavior

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Mac Sierra]
  • Python version [e.g. 3.6.8]

Additional context
Add any other information that you think could be useful for us.
@lepla
Copy link
Contributor

lepla commented Apr 24, 2022

Can this simple issue be assigned to me?

@DidierRLopes
Copy link
Collaborator

Done @lepla ! Thank you!

lepla added a commit to lepla/GamestonkTerminal that referenced this issue Apr 24, 2022
@lepla
[Bug] Incorrect log for reddit keys. OpenBB-finance#1733 fix
e0aabea
@lepla lepla mentioned this issue Apr 24, 2022
Merged
DidierRLopes pushed a commit that referenced this issue Apr 25, 2022
@lepla
[Bug] Incorrect log for reddit keys. #1733 fix (#1735)
e78998e
@piiq piiq added the bug Fix bug label Apr 25, 2022
@piiq
Copy link
Contributor

piiq commented Apr 25, 2022

Fixed by #1735

@piiq piiq closed this as completed Apr 25, 2022
DidierRLopes added a commit that referenced this issue May 14, 2022
@lepla @JerBouma
@jmaslek @colin99d @DidierRLopes
Feature/hedge (#1768)
54a1b6f 
* [Bug] Incorrect log for reddit keys. #1733 fix

* Create new feature-hedge

* Significantly improve code of hedge menu

* More robust

* Robustness

* Fix tests

* Fix can't multiply sequence by non-int of type 'numpy.float64' error

* Temporary fix of singular matrix error. Return first feasible solution

* Update Hugo Documentation

* Combining menus and cleaning up code

* Tidy up call_exp

* Update tests Round 1

* Update tests Round 2

* Fix linting error

* Fix linting?

* Fixed glitch

Co-authored-by: JerBouma <[email protected]>
Co-authored-by: James Maslek <[email protected]>
Co-authored-by: Colin Delahunty <[email protected]>
Co-authored-by: colin99d <[email protected]>
Co-authored-by: didierlopes.eth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lepla lepla

Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@piiq @penfold1972 @DidierRLopes @lepla