-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new method to access check run API #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 85.93% 84.43% -1.51%
==========================================
Files 14 14
Lines 775 790 +15
==========================================
+ Hits 666 667 +1
- Misses 109 123 +14
Continue to review full report at Codecov.
|
Other than foregoing the test, I think this is ready to go, @astrofrog . Perhaps this will be tested indirectly when you test a blueprint that uses this method? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor request but looks good otherwise!
Fix #34
No idea how to test this. And even if this
add_check
works, need to discuss how to actually use it, as it provides a lot more options than status checks.TODO
Update blueprints to use this.@astrofrog will do this part.Add tests.Cannot find a good way to test just the new method with mock and still have the test be useful.NOTES
PROOF OF CONCEPT
pllim/playpen#19 (Ops, the status check area disappeared when I closed the PR. But note that the checks also appear as statuses at the bottom of the PR like a regular status. Like Tom R said, checks are like fancy statuses.)