Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 5.0.0-beta3 #24

Closed
wants to merge 1 commit into from
Closed

Conversation

jrouly
Copy link
Contributor

@jrouly jrouly commented Nov 20, 2020

Just upgrades to the recently released 5.0.0-beta3.

@jrouly
Copy link
Contributor Author

jrouly commented Nov 20, 2020

cc @jimschubert

@jimschubert
Copy link
Member

These beta suffixes don't work with the versioning in the plugin release. We'd either need to fix that first, or stick with snapshots until the full 5.0.0 release.

@jrouly
Copy link
Contributor Author

jrouly commented Nov 27, 2020

@jimschubert Got it. I just saw #5 as well. If the bintray repo supports snapshots (looks like it does?) I'm totally happy to work with snapshots. Unfortunately the versioning in this repo is static so they're not getting published on merges.

I'm not sure if you're open to it, but I'd be happy to set up sbt-dynver for versioning instead (#25), which would handle snapshots and versioning a little more automatically - you'd just need to create tagged releases for the repo on Github to line up with dependency updates.

@jrouly
Copy link
Contributor Author

jrouly commented Nov 27, 2020

This also explains why I wasn't able to write a scripted test for my last PR adding the new SBT key - the version being submitted to the scripted test was the incorrect static version from master rather than the snapshot being built. I can submit a PR for that too now.

@jrouly jrouly closed this Nov 27, 2020
@jrouly jrouly deleted the 5.0.0-beta3 branch November 27, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants