Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-dio-next] only remove typed_data import if safe #9956

Merged

Conversation

MichaelMarner
Copy link
Contributor

This PR closes #9955 by only removing the import for dart:typed_data if there are no parameters AND no responses of type UInt8List.

Previously only parameters were being checked, meaning invalid dart code would be generated if there was a UInt8List response, because the import would have been removed.

Have tested against the example I provided in the bug report, as well as our own codebase where the error was first identified.

Have run ./bin/generate-samples.sh, but as the Petstore API does not have any file responses, there were no changes to the generated code.

@swipesight @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob (2020/12)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kuhnroyal
Copy link
Contributor

Good catch, thanks for the PR! Would you mind moving the whole block directly beneath L:324 and adding a comment that this needs to be done due to the MultipartFile handling above.

@wing328 wing328 added this to the 5.2.1 milestone Jul 16, 2021
@MichaelMarner MichaelMarner force-pushed the 9955-dart-dio-next-typed-data branch from 4eafc1d to aa4bfea Compare July 19, 2021 00:17
@MichaelMarner
Copy link
Contributor Author

Would you mind moving the whole block directly beneath L:324 and adding a comment that this needs to be done due to the MultipartFile handling above.

Done.

@MichaelMarner MichaelMarner force-pushed the 9955-dart-dio-next-typed-data branch from aa4bfea to 6cf91b1 Compare July 19, 2021 06:29
Copy link
Contributor

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed this on the original change!

@wing328
Copy link
Member

wing328 commented Jul 19, 2021

CircleCI failure not related to this change.

@wing328 wing328 merged commit e20ccd4 into OpenAPITools:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Dart-Dio-Next] removes import for typed_data
5 participants