Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#][netcore] Remove redundant logic in adding ICollection #9938

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 13, 2021

  • Remove redundant logic in adding ICollection in CSharpClientCodegen and CSharpNetCoreClientCodegen as these logics already present in the abstract C# codegen class.
  • No change to the samples.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)

@wing328 wing328 changed the title [C#][netcore] Remove reduce logic in adding IColletion [C#][netcore] Remove reducdant logic in adding IColletion Jul 13, 2021
@wing328 wing328 changed the title [C#][netcore] Remove reducdant logic in adding IColletion [C#][netcore] Remove reducdant logic in adding ICollection Jul 13, 2021
@wing328 wing328 changed the title [C#][netcore] Remove reducdant logic in adding ICollection [C#][netcore] Remove redundant logic in adding ICollection Jul 13, 2021
@wing328 wing328 marked this pull request as ready for review July 13, 2021 14:16
@wing328 wing328 added Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Jul 13, 2021
@wing328 wing328 added this to the 5.2.1 milestone Jul 13, 2021
@wing328 wing328 merged commit d99f16e into master Jul 16, 2021
@wing328 wing328 deleted the csharp-netcore-cleanup branch July 16, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant