Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] FIX: Generate documentation and examples #9857

Merged
merged 5 commits into from
Aug 7, 2021
Merged

[typescript] FIX: Generate documentation and examples #9857

merged 5 commits into from
Aug 7, 2021

Conversation

NouemanKHAL
Copy link
Contributor

Fix to the PR: #9413

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@NouemanKHAL NouemanKHAL force-pushed the noueman/typescript-doc-generation branch from be7f7f8 to 24575fc Compare June 29, 2021 10:12
@wing328
Copy link
Member

wing328 commented Jun 29, 2021

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@TiFu
Copy link
Contributor

TiFu commented Jul 10, 2021

@lwj5 Could you confirm whether this fixes the issue in #9413 when using your internal spec document?

Works for me with the dumbed-down version, but I'd like to make sure that we are not missing anything :)

@lwj5
Copy link
Contributor

lwj5 commented Jul 10, 2021

Thanks for the fix, I’m out right now. I’ll run it tonight and let you know ASAP.

@lwj5
Copy link
Contributor

lwj5 commented Jul 10, 2021

It works on the full document!

@NouemanKHAL
Copy link
Contributor Author

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@TiFu TiFu merged commit 74e28a7 into OpenAPITools:master Aug 7, 2021
@TiFu
Copy link
Contributor

TiFu commented Aug 7, 2021 •
edited
Loading

Apologies for the delay - Thank your for the PR, which has been merged into master.

TiFu added a commit that referenced this pull request Aug 7, 2021
@TiFu
Add missing samples for #9857
ccccb6a
@wing328 wing328 added this to the 5.2.1 milestone Aug 13, 2021
@wing328 wing328 changed the title [typescript] FIX: Generate documentation and examples #9413 [typescript] FIX: Generate documentation and examples Aug 16, 2021
ekilmer added a commit to ekilmer/openapi-generator that referenced this pull request Aug 16, 2021
@ekilmer
UNTESTED. Merge branch 'master' into inline-resolver.
668a202 
* master: (849 commits)
  Don't use encodeCollectionQueryParameter on maps (OpenAPITools#10116)
  Fixed the utc time issue for httpSigning auth. (OpenAPITools#10139)
  [dart][dio] Update built_value to =>8.1.0 (OpenAPITools#10122)
  Add Inquisico to list of generator users (OpenAPITools#10142)
  add my companies to README (OpenAPITools#10146)
  [C][Client] Allocate memory for the element of array when the type is number (OpenAPITools#10124)
  update samples
  Fixed typo in csharp-netcore httpclient generated code (OpenAPITools#10119)
  Typescript-angular: Added missing semi colon to interface export in `apis.ts` template file. (OpenAPITools#10121)
  Fix issue 10020: [BUG] [typescript-angular] Add "header" to reserved words (OpenAPITools#10091)
  Add missing samples for OpenAPITools#9857
  [typescript] FIX: Generate documentation and examples OpenAPITools#9413 (OpenAPITools#9857)
  Feat adds has discriminator with non empty mapping (OpenAPITools#9667)
  Add switches (authentication collections) to support files (OpenAPITools#9884)
  [dart-dio-next] improve encodeCollectionQueryParameter to handle cases where collectionFormat is null (OpenAPITools#10105)
  [go-server] Feat: add required assertions to models (OpenAPITools#10068)
  [dart2] Include request body on DELETE call (OpenAPITools#10100)
  Make php's array a primitive (OpenAPITools#10093)
  Fix typo (preffer -> prefer) (OpenAPITools#10098)
  Fix typo on rust client (OpenAPITools#10096)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: TypeScript Issue: Non-operational
Projects
None yet
Milestone
5.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@NouemanKHAL @wing328 @TiFu @lwj5