Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add @javax.annotation.Nonnull to required getters #9593

Merged
merged 3 commits into from
Jul 19, 2021
Merged

[Java] Add @javax.annotation.Nonnull to required getters #9593

merged 3 commits into from
Jul 19, 2021

Conversation

marcelstoer
Copy link
Contributor

@marcelstoer marcelstoer commented May 26, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

For the Kotlin->Java interoperability (i.e. generated Java code used in Kotlin project) it is paramount that required properties be tagged with JSR-305 @Nonnull annotations. The Kotlin compiler honors those annotations: https://kotlinlang.org/docs/java-interop.html#jsr-305-support. Hence, they need to be generated in addition to the Bean Validation @NotNull.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

@marcelstoer marcelstoer marked this pull request as ready for review May 26, 2021 21:20
@marcelstoer marcelstoer changed the title Add @javax.annotation.Nonnull to required getters [Java] Add @javax.annotation.Nonnull to required getters May 26, 2021
@wing328 wing328 added this to the 5.2.1 milestone Jul 19, 2021
@wing328 wing328 merged commit c5f5d3d into OpenAPITools:master Jul 19, 2021
@marcelstoer marcelstoer deleted the fix/nonnull branch July 19, 2021 06:28
@GithubUser8080
Copy link

Why did you add this even if bean validation is not selected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants