fix circular import issue in python flask #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheelsandmetal
force-pushed
the
python/server/fix-circular-imports
branch
from
eeb9c73 to
999fb5d
Compare
|
It would be possible to use |
wheelsandmetal
force-pushed
the
python/server/fix-circular-imports
branch
from
b2d511b to
9b94e91
Compare
This is very similar change to 3678eaf All it intends to do is fix the problem of cirular imports (which was already fixed for python) in the python flask server.
wheelsandmetal
force-pushed
the
python/server/fix-circular-imports
branch
from
9b94e91 to
d35e41b
Compare
|
If no one has further feedback/question, I'll merge it over the weekend. |
jaumard
pushed a commit
to jaumard/openapi-generator
that referenced
this pull request
Sep 21, 2018
* fix circular import issue in python flask This is very similar change to 3678eaf All it intends to do is fix the problem of cirular imports (which was already fixed for python) in the python flask server. * removal of type hints in quotes
|
@wheelsandmetal thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544 |
4 tasks
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* fix circular import issue in python flask This is very similar change to 3678eaf All it intends to do is fix the problem of cirular imports (which was already fixed for python) in the python flask server. * removal of type hints in quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar change to 3678eaf
All it intends to do is fix the problem of cirular imports (which was
already fixed for python) in the python flask server.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11)
Description of the PR
Fix for the python-flask server for this issue:, used the example from this PR.
The current open-api.yaml file is in OAIv3 spec and connexion doesn't support that yet:.
(Also first PR, please tell me where I can improve!)