-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds getAdditionalPropertiesIsAnyType to java schema classes #8908
Merged
spacether
merged 14 commits into
OpenAPITools:master
from
spacether:adds_additionalPropertiesIsAnyType
Mar 7, 2021
Merged
Adds getAdditionalPropertiesIsAnyType to java schema classes #8908
spacether
merged 14 commits into
OpenAPITools:master
from
spacether:adds_additionalPropertiesIsAnyType
Mar 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maValidationProperties
spacether
changed the title
Adds additional properties is any type
Adds getAdditionalPropertiesIsAnyType to java schema classes
Mar 6, 2021
…AdditionalPropertiesIsAnyType
The travis-ci error is unrelated to this change so I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds getAdditionalPropertiesIsAnyType/setAdditionalPropertiesIsAnyType to java schema classes
This is needed if one is generating classes for object schemas.
By default object schema includes additionalProperties = AnyType, so if this boolean is False, then one needs to generate a custom class for the object schema.
Tests added of X.getAdditionalPropertiesIsAnyType for:
This will be used in:
#8325
And will probably want to be used in go-experimental @wing328
We may want to replace isAdditionalPropertiesTrue with getAdditionalPropertiesIsAnyType @wing328
getAdditionalPropertiesIsAnyType applies to all schema models and is also set to true if the user manually defined an additionalProperties in their spec and its value is any type schema.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x