-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not processing enums in cpp-pistache-server #8886
Fix not processing enums in cpp-pistache-server #8886
Conversation
Defining a reusable enum as a component schema results in an empty class. Following changes are made: - activate 'postProcessModelsEnum' in 'AbstractCppCodegen' - modify model templates for the 'cpp-pistache-server' project As 'postProcessModelsEnum' is now available in the 'AbstactCppCodegen' the 'enumVars' variables are now available in mustache templates for all cpp based code generators. As the 'AbstractCppCodegen' was touched all cpp based samples were updated.
@mfyuce thanks for the PR. Is it correct to say that you've tested these changes locally and it works for your use cases? |
modules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
Outdated
Show resolved
Hide resolved
I tried it and it seems OK. |
Hi @wing328,
Yes, I did the tests for our use cases and it is usable for us. But, after server generation, we needed to do a bit manuel modification and then we were ok (delete all "EnumContainer"s, rename all "EnumContainer_anyOf"s to "EnumContainer"). May be @etherealjoy is telling about the same situation.
I checked qt server generation output and saw that the same situation is there, so, I thought it is a feature or sth... |
CI failure not related to this change. |
@mfyuce thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423 |
@wing328 thanks to you and to the team for the great work! |
Defining a reusable enum as a component schema results in a class that does not include enum values. Following changes are made:
Fixes #1317
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)