[Java] Additional enum type annotations #8389
Conversation
|
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) |
bin/configs/spring-mvc.yaml
Outdated
| @@ -10,3 +10,4 @@ additionalProperties: | |||
| hideGenerationTimestamp: "true" | |||
| serverPort: "8002" | |||
| additionalModelTypeAnnotations: '@com.fasterxml.jackson.annotation.JsonFilter(value = "filter-name");@com.fasterxml.jackson.annotation.JsonIgnoreProperties(value = "id")' | |||
| additionalEnumTypeAnnotations: '@com.fasterxml.jackson.annotation.JsonTypeName("myName")' | |||
There was a problem hiding this comment.
Seems to me the JsonTypeName is hardcoded to "myName" for all Enum models in the auto-generated code. What if the JsonTypeName is different for each Enum model?
There was a problem hiding this comment.
@wing328 this is just an example of usage/verify everything works. This feature is about adding common annotations to all enums
There was a problem hiding this comment.
@wing328 changed to @com.fasterxml.jackson.annotation.JsonFormat
|
@Zomzog can this PR be merged? |
…rator into additional-enum-type-annotations � Conflicts: � modules/openapi-generator/src/main/resources/Java/modelEnum.mustache � modules/openapi-generator/src/main/resources/Java/modelInnerEnum.mustache
|
I'll take a look tomorrow. Please put the restart on hold. |
Original issue: #6055
While original issue is about adding
additionalModelTypeAnnotationsto enum this is wrong solution since not all model annotations makes sence for enums. That's why I have added another option -additonalEnumTypeAnnotationsPR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master,5.1.x,6.0.x