Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] refactor: improve additionalModelTypeAnnotations generation #8269

Merged
merged 2 commits into from
Aug 17, 2021
Merged

[Java] refactor: improve additionalModelTypeAnnotations generation #8269

merged 2 commits into from
Aug 17, 2021

Conversation

UnleashSpirit
Copy link
Contributor

@UnleashSpirit UnleashSpirit commented Dec 24, 2020 •
edited
Loading

Split by ';' and/or newline
Trim value

fix: #7032

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@agilob
Copy link
Contributor

agilob commented Jan 4, 2021

Looking good, now you need to update the documentation explaining how to use it :)

@UnleashSpirit
Copy link
Contributor Author

Looking good, now you need to update the documentation explaining how to use it :)
Deal, from where I start ?
And what (how) do I do with your comment above about the README with generate-samples.sh ?

@agilob
Copy link
Contributor

agilob commented Jan 4, 2021

You need to update documentation of additionalModelTypeAnnotations in one of the readme files

@UnleashSpirit UnleashSpirit force-pushed the fix_issue7032 branch 3 times, most recently from b47bf5e to a9ecc7d Compare January 6, 2021 14:48
@agilob
Copy link
Contributor

agilob commented Jan 7, 2021

I think it's good to go, do the last step listed in PR description

Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@UnleashSpirit
Copy link
Contributor Author

UnleashSpirit commented Jan 7, 2021 •
edited
Loading

I think it's good to go, do the last step listed in PR description

Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Hi thanks for approval.
I did not copy anyone cause it's a bit general no ? Or may be Java ?

EDIT: yeah Java :)
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@UnleashSpirit
Copy link
Contributor Author

Any news about integration of this PR ?

@UnleashSpirit UnleashSpirit force-pushed the fix_issue7032 branch 2 times, most recently from dc13cdf to 4531a72 Compare May 20, 2021 06:14
@UnleashSpirit UnleashSpirit force-pushed the fix_issue7032 branch 2 times, most recently from e0cdeaf to 0f4d348 Compare May 25, 2021 08:35
@UnleashSpirit UnleashSpirit changed the title refactor: improve additionalModelTypeAnnotations generation [Java] refactor: improve additionalModelTypeAnnotations generation May 27, 2021
@UnleashSpirit UnleashSpirit force-pushed the fix_issue7032 branch 2 times, most recently from a8f7419 to cce8495 Compare June 3, 2021 15:43
@UnleashSpirit
refactor: improve additionalModelTypeAnnotations generation
f1c3b1f 
Split by ';' and/or newline
Trim value

fix: OpenAPITools#7032

Run ./bin/generate-samples.sh to regenerate model files

Revert "Run ./bin/generate-samples.sh to regenerate model files"

This reverts commit da509c39f363da046fbd457e1ab67ef0f62f3561.

refector: remove unnecessary import

test: multiples tests for AdditionalModelTypeAnnotations

Add a getter to test the list

refactor: remove duplicate AdditionalModelTypeAnnotations

Without using Set to avoid any side effect somewhere, I use stream and
distinct to avoid duplicates

refactor: using Set instead of stream

Remove stream distinct for performance reason, use newHashSet
Keep AdditionalModelTypeAnnotations as List

doc: update info additionalModelTypeAnnotations

refactor: move doc in code for autogen

style: tab in java class

doc: run ensure-up-to-date

refactor: add imports lost in rebase

docs: regenerate docs

docs: update
@agilob
Copy link
Contributor

agilob commented Aug 17, 2021

Run this:

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

review and commit changes to fix broken test

@UnleashSpirit
Copy link
Contributor Author

Run this:

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

review and commit changes to fix broken test

Done :)

@agilob
Copy link
Contributor

agilob commented Aug 17, 2021

@wing328 can we have it in pls?

@wing328 wing328 merged commit 9ece1b5 into OpenAPITools:master Aug 17, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilob agilob agilob approved these changes

Assignees
No one assigned
Labels
Client: Groovy Client: Java Enhancement: General Server: Java
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

[REQ] Improvment additionalModelTypeAnnotations
3 participants
@UnleashSpirit @agilob @wing328