Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart] Use raw strings for json/header parameter names #8131

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

kuhnroyal
Copy link
Contributor

This should fix all problems related to unescaped characters in strings that are assumed to be raw - e.g. json['$special[property.name]'] -> json[r'$special[property.name]'].

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @agilob

This should fix all problems related to unescaped characters in strings that are assumed to be raw - e.g. `json[r'$special[property.name]']`
@wing328 wing328 added this to the 5.0.0 milestone Dec 9, 2020
@wing328
Copy link
Member

wing328 commented Dec 9, 2020

CircleCI failure not related to this change.

@wing328 wing328 merged commit 144e08b into OpenAPITools:master Dec 9, 2020
@kuhnroyal kuhnroyal deleted the dart/raw-strings branch December 9, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants