Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger parser to 2.0.23 #8128

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Update swagger parser to 2.0.23 #8128

merged 3 commits into from
Dec 10, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Dec 8, 2020

Update swagger parser to 2.0.23.

Reviewed the release note and the changes are pretty minor: https://github.com/swagger-api/swagger-parser/releases

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 changed the title Update swagger parser to 2.0.23 Update swagger parser to 2.0.24 Dec 9, 2020
@wing328 wing328 added this to the 5.0.0 milestone Dec 9, 2020
This reverts commit d971477.
@wing328 wing328 changed the title Update swagger parser to 2.0.24 Update swagger parser to 2.0.23 Dec 9, 2020
@wing328
Copy link
Member Author

wing328 commented Dec 9, 2020

FYI. Tried updating to 2.0.24 but one or two unit tests failed.

@wing328 wing328 merged commit d2f9d42 into master Dec 10, 2020
@wing328 wing328 deleted the swagger-parser-upgrade-23 branch December 10, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant