[dart] Variable/Operation/Model naming #8123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
CC @josh-burton |
josh-burton
approved these changes
Dec 8, 2020
kuhnroyal
force-pushed
the
dart/variable-naming
branch
from
1ddbbd8 to
3b62d3d
Compare
* note: public and private are no keywords in Dart * some tests are still wrong, some are commented out
* add more tests
* use same handling for all 3 generators * allow `updateEnumVarsWithExtensions` to have access to the data type * improve `x-enum-values` handling and add supprt for other enum vendor extensions * remove duplicate and outdated tests from `DartDioModelTest` * add more tests to `DartModelTest` * no longer force lowercase enums for plain dart generator (breaking) * this change also removes the trailing underscore from plain dart generator (breaking)
kuhnroyal
force-pushed
the
dart/variable-naming
branch
from
3b62d3d to
0e4f449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Var/Model
double->double_Enums:
updateEnumVarsWithExtensionsto have access to the data typex-enum-valueshandling and add support for other enum vendor extensionsDartDioModelTestDartModelTestPotential fixes for:
#7867
#5794
#5627
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master