Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug [python][client] generated python client code cannot POST object in multipart/form-data #8075

Merged
merged 7 commits into from
Dec 7, 2020

Conversation

itaru2622
Copy link
Contributor

as described in #8068 , encode object to json and add 'content-type:application/json' for sending multipart/form-data.
and checked if the request is sent to server with collect format described in #8068.

fix #8068

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether @wing328 @jimschubert

@auto-labeler
Copy link

auto-labeler bot commented Dec 2, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

"""
new_params = []
if collection_types is None:
collection_types = (dict,list)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should fix my mistake about line 259, as below:

        if collection_types is None:
-          collection_types = (dict,list)
+          collection_types = (dict)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above is fixed by a6c8d1a.

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for the PR and the update!

@spacether spacether added this to the 5.0.0 milestone Dec 7, 2020
@spacether spacether merged commit 35d616c into OpenAPITools:master Dec 7, 2020
@itaru2622 itaru2622 deleted the fix8068 branch February 24, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] generated python client code cannot send object in multipart/form-data
2 participants