-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug [python][client] generated python client code cannot POST object in multipart/form-data #8075
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
modules/openapi-generator/src/main/resources/python/api_client.mustache
Outdated
Show resolved
Hide resolved
…part/form-data fix issue OpenAPITools#8068
…t-type:application/json; charset=utf-8"
… discussion in PR review.
… PR review comment.
""" | ||
new_params = [] | ||
if collection_types is None: | ||
collection_types = (dict,list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should fix my mistake about line 259, as below:
if collection_types is None:
- collection_types = (dict,list)
+ collection_types = (dict)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the above is fixed by a6c8d1a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you for the PR and the update!
as described in #8068 , encode object to json and add 'content-type:application/json' for sending multipart/form-data.
and checked if the request is sent to server with collect format described in #8068.
fix #8068
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether @wing328 @jimschubert