-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C][Client] Support progress function of libcurl #7974
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Please merge the latest master into this branch, which should fix the CI failures. |
Sure. I will do it. |
0f1c212
to
f9365e7
Compare
Hi @wing328 I have merged (git rebase upstream/master) the master code on yesterday evening. But ci/circleci: build still failed. |
Looks like https://repo.maven.apache.org:443 was throttling our connections as the project is too active.
Just restarted the circleci job. Let's see how that goes. |
Thank you @wing328 |
Hi @wing328 @zhemant @michelealbano
This is a feature enhancement.
libcurl has a mechanism of progress callback function.
https://curl.se/libcurl/c/CURLOPT_XFERINFOFUNCTION.html
That can be used to do some operation ( e.g. display download/upload progress information ) when the transfer is in progress.
This PR introduces this feature into c client.
It also can be used to stop an endless http(s) request. The detail can be found at kubernetes-client/c#39
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master