Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Support progress function of libcurl #7974

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Nov 18, 2020

Hi @wing328 @zhemant @michelealbano

This is a feature enhancement.
libcurl has a mechanism of progress callback function.
https://curl.se/libcurl/c/CURLOPT_XFERINFOFUNCTION.html
That can be used to do some operation ( e.g. display download/upload progress information ) when the transfer is in progress.
This PR introduces this feature into c client.

It also can be used to stop an endless http(s) request. The detail can be found at kubernetes-client/c#39

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Nov 18, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.0 milestone Nov 19, 2020
@ityuhui ityuhui closed this Nov 23, 2020
@ityuhui ityuhui reopened this Nov 23, 2020
@wing328
Copy link
Member

wing328 commented Nov 23, 2020

Please merge the latest master into this branch, which should fix the CI failures.

@ityuhui
Copy link
Contributor Author

ityuhui commented Nov 23, 2020

Please merge the latest master into this branch, which should fix the CI failures.

Sure. I will do it.

@ityuhui
Copy link
Contributor Author

ityuhui commented Nov 24, 2020

Hi @wing328

I have merged (git rebase upstream/master) the master code on yesterday evening. But ci/circleci: build still failed.
Are you sure the latest code has fixed the CI failure ?

@wing328
Copy link
Member

wing328 commented Nov 24, 2020

Looks like https://repo.maven.apache.org:443 was throttling our connections as the project is too active.

Nov 23, 2020 1:42:39 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection reset
Nov 23, 2020 1:42:39 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Nov 23, 2020 1:42:39 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection reset
Nov 23, 2020 1:42:39 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Nov 23, 2020 1:42:39 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection reset
Nov 23, 2020 1:42:39 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443

Just restarted the circleci job. Let's see how that goes.

@ityuhui ityuhui closed this Nov 25, 2020
@ityuhui ityuhui reopened this Nov 25, 2020
@wing328 wing328 merged commit 4dc8d2a into OpenAPITools:master Nov 25, 2020
@ityuhui
Copy link
Contributor Author

ityuhui commented Nov 26, 2020

Thank you @wing328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants