Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java/okhttp] Add dynamic operations option #7916

Merged
merged 5 commits into from
Dec 10, 2020

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Nov 10, 2020

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

This PR adds support for dynamic operations.
When the option is selected, the generated code will get the details for the operations from an OAS that is provided at runtime. The generated code will look for operationId and the parameter names in this OAS to build the requests.
This way the client is more decoupled from the server. You can make changes in the server API and the client will still work without needing to be regenerated. This is a major gain when ensuring the client is up-to-date is hard (eg. mobile apps).

Examples of API changes that keep compatibility with dynamic clients (and that break non-dynamic clients):

  • Changing the operation URL (eg changing /api/user/{id} to /api/users/{id})
  • Changing the operation method (eg. a POST becomes a PUT)
  • Moving an operation parameter between path, header and cookie

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the feature is off by default, I'm happy to include it in the upcoming 5.0.0 release.

@wing328 wing328 merged commit f2d8e3a into OpenAPITools:master Dec 10, 2020
@cbornet cbornet deleted the dynamic-operations branch December 10, 2020 10:28
@wing328 wing328 added this to the 5.0.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants