Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows install typescript client via npm from Git #7878

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Allows install typescript client via npm from Git #7878

merged 2 commits into from
Nov 24, 2020

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Nov 4, 2020

'prepublishOnly' is run before the package is published. 'prepack' is run before the package is published and after local installation eg. via Git.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

'prepublishOnly' is run before the package is published. 'prepack' is run before the package is published and after installation local installation eg. via Git.
@macjohnny
Copy link
Member

cc @TiFu

@macjohnny macjohnny requested a review from TiFu November 17, 2020 13:49
@ad-m ad-m marked this pull request as ready for review November 17, 2020 14:58
@ad-m
Copy link
Contributor Author

ad-m commented Nov 17, 2020

Thank you for reminding me about the issue. I rebuilt samples.

@TiFu
Copy link
Contributor

TiFu commented Nov 22, 2020

Thank you for the PR! The changes look good to me and the Shippable error seems to be unrelated.

Edit: Just going to trigger CI again to see if we can Shippable to work. Going to merge by the end of this week.

@TiFu TiFu closed this Nov 22, 2020
@TiFu TiFu reopened this Nov 22, 2020
@macjohnny macjohnny added this to the 5.0.0 milestone Nov 24, 2020
@macjohnny macjohnny merged commit be07bd1 into OpenAPITools:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants