Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct allOf with only one child schema (no discriminator) #7855

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 2, 2020

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 marked this pull request as ready for review November 2, 2020 10:11
@wing328 wing328 changed the title Correct allOf with only one child schema (no discriminator Correct allOf with only one child schema (no discriminator) Nov 2, 2020
@wing328 wing328 added this to the 5.0.0 milestone Nov 2, 2020
@wing328 wing328 merged commit 4984f9c into master Nov 23, 2020
@wing328 wing328 deleted the fix-allof-single2 branch November 23, 2020 09:16
@rivancic
Copy link

rivancic commented Jul 29, 2022

Why would I need to use discriminator if I only have one reference in allOf. In this case it's clear that only this single referenced
schema can be a parent schema and in Java it should extend this single parent schema.

For schema

    ResponseRefSchema:
      description: >-
        TestInformation should be ResponseRefSchema parent even without discriminator 
      type: object
      allOf:
        - $ref: "#/components/schemas/TestInformation"

result should be

public class ResponseRefSchema extends TestInformation  {
...

Logic in ModelUtils#getParentName() should be like following:

If (only one interface) then 
  hasAmbiguousParents = false;

or

if (only one interface) then
  return parentName;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants