Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose JsonSerializerSettings in ApiClient #7582

Merged

Conversation

davidyee
Copy link
Contributor

@davidyee davidyee commented Oct 2, 2020

In this PR, I expose the JsonSerializerSettings in the ApiClient so that serialization customizations can be done. For example, in my specific use-case, I wanted to add additional Converters to change the way JSON was being deserialized back into the csharp classes.

Fixes #4241

I reviewed the comments made on this related PR #4466 and incorporated the feedback into this PR.

@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Member

wing328 commented Oct 3, 2020

@davidyee thanks for the PR. I wonder if you can add a new ApiClientTests.cs file to test JsonSerializerSettings

A good reference is ConfigurationTests.cs

Ref: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools.Test/ConfigurationTests.cs

@wing328
Copy link
Member

wing328 commented Oct 5, 2020

FYI. I've filed #7583 to default OverrideSpecifiedNames to false. Let me know if you've any concerns.

@davidyee davidyee force-pushed the feature/add-custom-json-serializer branch from 16ad51a to ed2e5a2 Compare October 12, 2020 03:35
@davidyee davidyee force-pushed the feature/add-custom-json-serializer branch from ed2e5a2 to 7cf23cd Compare October 12, 2020 03:39
@davidyee
Copy link
Contributor Author

@wing328 Thanks for the feedback and suggestions. I've included revisions to my PR in my latest commits.

@wing328 wing328 added this to the 5.0.0 milestone Nov 26, 2020
@wing328 wing328 merged commit cf185d5 into OpenAPITools:master Nov 26, 2020
@wing328
Copy link
Member

wing328 commented Nov 26, 2020

@davidyee thanks for the PR, which has been merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [csharp-netcore] Custom JsonSerializer needed
2 participants