Fix incorrect enum values for typescript clients #7370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
* Properly decode $ref fixes #5720 * Specify decoding encoding * Nicer syntax * UTF-8 typo * Unescape special characters * Change order of unescaping to prevent escaped sequences by accident * Comment for special decoding Co-authored-by: Jim Schubert <[email protected]> * Add unit test for simple ref decoding Co-authored-by: Jim Schubert <[email protected]>
macjohnny
requested changes
Sep 9, 2020
| @@ -690,9 +690,9 @@ private String getNameUsingEnumPropertyNaming(String name) { | |||
| case original: | |||
| return name; | |||
| case camelCase: | |||
| return camelize(name, true); | |||
| return camelize(StringUtils.lowerCase(name), true); | |||
There was a problem hiding this comment.
I think this breaks the behavior if e.g. name is someEnumValue, which would incorrectly result in someenumvalue, as opposed to someEnumValue
| case PascalCase: | ||
| return camelize(name); | ||
| return camelize(StringUtils.lowerCase(name)); |
There was a problem hiding this comment.
I think this breaks the behavior if e.g. name is someEnumValue, which would incorrectly result in someenumvalue, as opposed to SomeEnumValue
|
this is a breaking change, but the fallback is to use |
added 3 commits
September 9, 2020 11:19
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractTypeScriptClientCodegen.java # modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptAxiosClientCodegenTest.java
|
replaced by #7378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7369
Enum values are generated incorrectly for PascalCase enum property naming type when the source enum values are in uppercase with underscores.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master