-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift5] fix issues causing stack overflow #7301
Merged
wing328
merged 3 commits into
OpenAPITools:master
from
Donkov76:bugfixSwift5CodeGeneration-2966
Sep 6, 2020
Merged
[Swift5] fix issues causing stack overflow #7301
wing328
merged 3 commits into
OpenAPITools:master
from
Donkov76:bugfixSwift5CodeGeneration-2966
Sep 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
approved these changes
Sep 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and confirmed no longer seeing stackoverflow
wing328
changed the title
Bugfix swift5 code generation 2966
[Swift5] fix issues causing stack overflow
Sep 6, 2020
jimschubert
added a commit
to lwlee2608/openapi-generator
that referenced
this pull request
Sep 12, 2020
* master: (1557 commits) [docs] Add notes on Windows classpath modification (OpenAPITools#7404) [C#][netcore] better support for additional properties in the payload (OpenAPITools#7396) Fix the ECDSA signature issue for PowerShellSDK (OpenAPITools#7386) Fix the new package that deal with Configuration (the old one is depecrated) (OpenAPITools#7391) update vonage logo (OpenAPITools#7387) [gradle][plugin] Fix tests (OpenAPITools#7384) [typescript] Fix incorrect enum literal case (OpenAPITools#7378) Rust reqwest/api_mustache Missing api Vec in parameter (OpenAPITools#7049) [kotlin] Fix imports of generated class (OpenAPITools#7314) Properly decode $ref (OpenAPITools#7191) fix typo, update caption feat(r): retry configuration for status codes (OpenAPITools#5925) [json][codegen] Add option: outputFileName (OpenAPITools#7348) RSACng class is not supported on linux replacing it by RSA (OpenAPITools#7349) Adds cookie auth support to ApiKeyAuth in dart2 templates (OpenAPITools#7346) [js][flowtype] Bump lodash from 4.17.15 to 4.17.19 (OpenAPITools#7359) Bugfix swift5 code generation 2966 (OpenAPITools#7301) Syncs validation properties for arraymodels (OpenAPITools#7357) Subclass Python exceptions (OpenAPITools#7321) Adds fix for issue7262 and a test of it (OpenAPITools#7328) ...
wing328
added a commit
that referenced
this pull request
Dec 2, 2020
fix for the stackoverflow issue
6 tasks
wing328
added a commit
that referenced
this pull request
Dec 2, 2020
…ter (#8066) fix for the stackoverflow issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #2966.
The Crash occurs in Swift5 and Swift4 CodeGeneration.
swift4 has been marked as deprecated, so I only fixed the Swift5CodeGeneration.
UnitTest: crashSwift5ExampleCodeGenerationStackOverflowTest()