Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#][csharp-netcore] Improvement to standard code format #7206

Merged
merged 2 commits into from
Aug 14, 2020
Merged

[C#][csharp-netcore] Improvement to standard code format #7206

merged 2 commits into from
Aug 14, 2020

Conversation

shibayan
Copy link
Contributor

Fixed some parts of the code format generated by csharp-netcore clients that were not common in C# (e.g. Roslyn, CoreFx)
I focused on the issues detected using dotnet-format.

  • using order
  • unnecessary or missing space
  • different indents

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

@auto-labeler
Copy link

auto-labeler bot commented Aug 13, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 closed this Aug 14, 2020
@wing328 wing328 reopened this Aug 14, 2020
@wing328 wing328 added this to the 5.0.0 milestone Aug 14, 2020
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement to the code format 👍

@wing328 wing328 merged commit b6f1f01 into OpenAPITools:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants