Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avro] Default value for no required fields to null #7006

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

patou
Copy link
Contributor

@patou patou commented Jul 21, 2020

When a field is not required, the avro schema has no default value.
Has described in an avro issues, the property default: null must be set.

If we don't do this in the avro file, when we generate java code from generated avro schema, the builder fail if the data isn't set in the avro data class.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

When a field is not required, the avro schema has no default value.
Has described in an [avro issues](https://issues.apache.org/jira/browse/AVRO-1803), the property default: null must be set.

If we don't do this in the avro file, when we generate java code from generated avro schema, the builder fail if the data isn't set in the avro data class.
@patou patou changed the title Default value for the non required fields to null [Avro] Default value for the non required fields to null Jul 21, 2020
@wing328
Copy link
Member

wing328 commented Jul 21, 2020

cc @sgadouar

@sgadouar
Copy link
Contributor

i agree, must add "default": null id the field is nullable

@wing328 wing328 added Issue: Bug Schema: Avro Generation of Avro schemas labels Jul 21, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jul 21, 2020
@patou patou changed the title [Avro] Default value for the non required fields to null [Avro] Default value for no required fields to null Jul 21, 2020
@wing328 wing328 merged commit b1dcf65 into OpenAPITools:master Jul 22, 2020
@patou patou deleted the patch-1 branch July 22, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Schema: Avro Generation of Avro schemas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants