[Dart] Treat float as double

[sbu-WBT]

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

	{{#isDouble}}
	{{name}} = (json['{{baseName}}'] == null) ?
	null :
	json['{{baseName}}'].toDouble();
	{{/isDouble}}
	{{^isDouble}}
	{{name}} = json['{{baseName}}'];
	{{/isDouble}}

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

[agilob]

Can we get a test for it pls?

[wing328]

       {{#isDouble}} 
 {{name}} = (json['{{baseName}}'] == null) ? 
   null : 
   json['{{baseName}}'].toDouble(); 
       {{/isDouble}} 
       {{^isDouble}} 
 {{name}} = json['{{baseName}}']; 
       {{/isDouble}} 

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

[sbu-WBT]

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

[wing328]

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

[sbu-WBT]

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

[wing328]

Shippable CI failure not related to this PR.

[wing328]

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore