Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Pistache] Catch HttpError from user-provided handler #6520

Merged

Conversation

muttleyxd
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03)

I tried to use Pistache::Http::serveFile, and it works, but when the file does not exist, then it will return 500, instead of 404. That's because it throws Pistache::Http::HttpError with 404 code, but it's being caught by catch (std::exception &) and 500 is returned afterwards, despite original exception having more information.

void MyHandlers::getFile(std::string const& path, Pistache::Http::ResponseWriter& response)
{
    Pistache::Http::serveFile(response, path.get());
}

Also this will allow user to use exceptions to signal errors to REST API caller:

void MyHandlers::someEndpoint(Pistache::Http::ResponseWriter& response)
{
    if (some_precondition_failed())
        throw Pistache::Http::HttpError(500, "precondition has failed");
    response.send(Pistache::Http::Code::Ok, "Success");
}

@etherealjoy etherealjoy added this to the 5.0.0 milestone Jun 5, 2020
@etherealjoy etherealjoy merged commit c102ced into OpenAPITools:master Jun 5, 2020
@muttleyxd muttleyxd deleted the pistache-server-catch-http-error branch June 5, 2020 15:26
jimschubert added a commit that referenced this pull request Jun 6, 2020
* master:
  Fix typescript generator for parameter collectionFormat for pipes ssv (#6553)
  [C++][Pistache] Catch HttpError from user-provided handler (#6520)
  remove scala related profile from the pom (#6554)
  move ruby tests to travis (#6555)
  [Java][jersey2] fix cast error for default value in DateTimeOffset object (#6547)
  [Swift] fix GET request with array parameter (#6549)
  [kotlin][spring] Fix ApiUtil compilation (#6084)
  update python samples
  [Python] Fixed docstrings in api.mustache (#6391)
  [BUG][python] Support named arrays (#6493)
  [Go] whitelist AdditionalProperties in the field name (#6543)
  [kotlin][client] remove tabs usage (#6526)
  [PS] automatically derive discriminator mapping for oneOf/anyOf  (#6542)
  [C++][Ue4] various bus fixes (#6539)
  Fix incorrect npx command (#6537)
  update pester to 5.x (#6536)
  comment out openapi3 java jersey2-java8 tests
  add additional properties support to powershell client generator (#6528)
  [Go][Experimental] Support additionalProperties (#6525)
  #5476 [kotlin] [spring] fix swagger and spring annotation for defaultValue (#6101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants